Fix strong drum rolls being counted for double the combo in legacy scoring attributes #30917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the root cause of a multi-system failure that ultimately causes ppy/osu-web#11697. It appears that my theory I described in that issue is correct, although this root failure is a little more specific than I initially suspected - only maps with strong drum rolls are affected, rather than maps with any drum rolls at all.
Around 6k beatmaps in total are affected by this. List available here: https://gist.github.com/bdach/a719beed292ef0632dc8d002eb9b274c
Caution
Intended for @peppy first and foremost:
This change affects total score for all scores imported from stable which were set on the affected beatmaps in the new database tables. Therefore, this pull should be followed up with:
osu-queue-score-statistics(I'd ask to hold with doing that until verification can correctmaximum_statistics, which also are affected by this failure and cause further failures down the stack, as described in the issue thread -working on that as I write thissee Add capability to verify maximum statistics of scores osu-queue-score-statistics#306).I ran a sheet locally and it looks as I'd expect it to, but will run one through the workflow here for transparency.
run all ranked
run from 90634 non-ranked